Repository: mesos Updated Branches: refs/heads/master aa17a6572 -> 1b87cd5dc
Added document about reopening old reviews. This describes some guidelines for reopening reviews that have been closed due to inactivity. Review: https://reviews.apache.org/r/49847/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/1b87cd5d Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/1b87cd5d Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/1b87cd5d Branch: refs/heads/master Commit: 1b87cd5dcdb7644fb0f74f52ce11bd8d9357619b Parents: aa17a65 Author: Joseph Wu <jos...@mesosphere.io> Authored: Sun Jul 10 00:35:03 2016 +0200 Committer: Joris Van Remoortere <joris.van.remoort...@gmail.com> Committed: Sun Jul 10 00:35:03 2016 +0200 ---------------------------------------------------------------------- docs/home.md | 1 + docs/reopening-reviews.md | 23 +++++++++++++++++++++++ 2 files changed, 24 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/1b87cd5d/docs/home.md ---------------------------------------------------------------------- diff --git a/docs/home.md b/docs/home.md index 8071013..5e6225c 100644 --- a/docs/home.md +++ b/docs/home.md @@ -82,6 +82,7 @@ layout: documentation * [Reporting an Issue, Improvement, or Feature](reporting-a-bug.md) for getting started with JIRA. * [Submitting a Patch](submitting-a-patch.md) for getting started with ReviewBoard and our tooling around it. +* [Reopening a Review](reopening-reviews.md) for our policy around reviving reviews on ReviewBoard. * [Testing Patterns](testing-patterns.md) for tips and tricks used in Mesos tests. * [Effective Code Reviewing](effective-code-reviewing.md) guidelines, tips, and learnings for how to do effective code reviews. * [Engineering Principles and Practices](engineering-principles-and-practices.md) to serve as a shared set of project-level values for the community. http://git-wip-us.apache.org/repos/asf/mesos/blob/1b87cd5d/docs/reopening-reviews.md ---------------------------------------------------------------------- diff --git a/docs/reopening-reviews.md b/docs/reopening-reviews.md new file mode 100644 index 0000000..fe50468 --- /dev/null +++ b/docs/reopening-reviews.md @@ -0,0 +1,23 @@ +--- +title: Apache Mesos - Reopening Reviews +layout: documentation +--- + +# Reopening Reviews + +Sometimes, a review you've submitted may fall through the cracks. +In general, we will close reviews on [Review Board](https://reviews.apache.org) +that show no activity for several months. Before you reopen the review, +consider taking the following steps to avoid a repeat scenario: + +* Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/mesos/) + associated with your review. The JIRA should be "accepted" by another + member of the community and you should be assigned to the issue. +* Check in with the [community](/community) and see if there is interest. + * For bug fixes or documentation updates, you should + [contact the maintainer(s)](committers.md). + * For improvements or new features, you should [find a shepherd](submitting-a-patch.md) + to collaborate on your design and review. +* Update your review. Chances are, the codebase has changed significantly + since you last uploaded the review. Also make sure your review's summary + is sensible and the description explains the problem and proposed solution.
