Fixed comment typos and whitespace infelicities. Review: https://reviews.apache.org/r/50339/
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/bc206279 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/bc206279 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/bc206279 Branch: refs/heads/master Commit: bc2062791d0e0e743e799409f4ba60d40c537888 Parents: b017d706 Author: Neil Conway <neil.con...@gmail.com> Authored: Wed Jul 27 16:58:41 2016 -0700 Committer: Vinod Kone <vinodk...@gmail.com> Committed: Wed Jul 27 16:58:41 2016 -0700 ---------------------------------------------------------------------- src/tests/authorization_tests.cpp | 21 ++++++++++----------- src/tests/slave_authorization_tests.cpp | 2 +- 2 files changed, 11 insertions(+), 12 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/bc206279/src/tests/authorization_tests.cpp ---------------------------------------------------------------------- diff --git a/src/tests/authorization_tests.cpp b/src/tests/authorization_tests.cpp index 38885ca..5d7e17b 100644 --- a/src/tests/authorization_tests.cpp +++ b/src/tests/authorization_tests.cpp @@ -1583,14 +1583,14 @@ TYPED_TEST(AuthorizationTest, ViewFramework) ASSERT_SOME(create); Owned<Authorizer> authorizer(create.get()); - // Create FrameworkInfo with a generic user as object to authorized. + // Create FrameworkInfo with a generic user as object to be authorized. FrameworkInfo frameworkInfo; { frameworkInfo.set_user("user"); frameworkInfo.set_name("f"); } - // Create FrameworkInfo with user "bar" as object to authorized. + // Create FrameworkInfo with user "bar" as object to be authorized. FrameworkInfo frameworkInfoBar; { frameworkInfoBar.set_user("bar"); @@ -1768,14 +1768,14 @@ TYPED_TEST(AuthorizationTest, ViewTask) taskBar.set_user("bar"); } - // Create FrameworkInfo with a generic user as object to authorized. + // Create FrameworkInfo with a generic user as object to be authorized. FrameworkInfo frameworkInfo; { frameworkInfo.set_user("user"); frameworkInfo.set_name("f"); } - // Create FrameworkInfo with user "bar" as object to authorized. + // Create FrameworkInfo with user "bar" as object to be authorized. FrameworkInfo frameworkInfoBar; { frameworkInfoBar.set_user("bar"); @@ -2001,14 +2001,14 @@ TYPED_TEST(AuthorizationTest, ViewExecutor) executorInfoNoUser.mutable_command()->set_value("echo hello"); } - // Create FrameworkInfo with a generic user as object to authorized. + // Create FrameworkInfo with a generic user as object to be authorized. FrameworkInfo frameworkInfo; { frameworkInfo.set_user("user"); frameworkInfo.set_name("f"); } - // Create FrameworkInfo with user "bar" as object to authorized. + // Create FrameworkInfo with user "bar" as object to be authorized. FrameworkInfo frameworkInfoBar; { frameworkInfoBar.set_user("bar"); @@ -2086,7 +2086,7 @@ TYPED_TEST(AuthorizationTest, ViewExecutor) } -// This tests the authorization of sandboxe access. +// This tests the authorization of sandbox access. TYPED_TEST(AuthorizationTest, SandBoxAccess) { // Setup ACLs. @@ -2154,14 +2154,14 @@ TYPED_TEST(AuthorizationTest, SandBoxAccess) executorInfoNoUser.mutable_command()->set_value("echo hello"); } - // Create FrameworkInfo with a generic user as object to authorized. + // Create FrameworkInfo with a generic user as object to be authorized. FrameworkInfo frameworkInfo; { frameworkInfo.set_user("user"); frameworkInfo.set_name("f"); } - // Create FrameworkInfo with user "bar" as object to authorized. + // Create FrameworkInfo with user "bar" as object to be authorized. FrameworkInfo frameworkInfoBar; { frameworkInfoBar.set_user("bar"); @@ -2313,7 +2313,6 @@ TYPED_TEST(AuthorizationTest, ViewFlags) ASSERT_SOME(create); Owned<Authorizer> authorizer(create.get()); - { authorization::Request request; request.set_action(authorization::VIEW_FLAGS); @@ -2393,7 +2392,7 @@ TYPED_TEST(AuthorizationTest, ValidateEndpoints) // This tests the authorization of requests to ViewRole. TYPED_TEST(AuthorizationTest, ViewRole) { - // Setup ACLs. + // Setup ACLs. ACLs acls; { http://git-wip-us.apache.org/repos/asf/mesos/blob/bc206279/src/tests/slave_authorization_tests.cpp ---------------------------------------------------------------------- diff --git a/src/tests/slave_authorization_tests.cpp b/src/tests/slave_authorization_tests.cpp index 4a66126..6f120b6 100644 --- a/src/tests/slave_authorization_tests.cpp +++ b/src/tests/slave_authorization_tests.cpp @@ -142,7 +142,7 @@ TYPED_TEST(SlaveAuthorizerTest, FilterStateEndpoint) Try<Owned<cluster::Master>> master = this->StartMaster(authorizer.get()); ASSERT_SOME(master); - // Resgister framework with user "bar". + // Register framework with user "bar". FrameworkInfo frameworkInfo = DEFAULT_FRAMEWORK_INFO; frameworkInfo.set_role("role"); frameworkInfo.set_user("bar");
