Repository: mesos
Updated Branches:
  refs/heads/master fbaeb5f37 -> f833169b4


Fixed an incorrect use of ASSERT_EQ.

This assertion calls ASSERT_EQ(expect, actual) as if it was
ASSERT_EQ(actual, expect). This matters because otherwise
when the assertion fails it prints confusing output.


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/f833169b
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/f833169b
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/f833169b

Branch: refs/heads/master
Commit: f833169b479a2715e78199bb399597499adf54d4
Parents: fbaeb5f
Author: Jiang Yan Xu <xuj...@apple.com>
Authored: Sun Sep 4 01:14:55 2016 -0700
Committer: Jiang Yan Xu <xuj...@apple.com>
Committed: Tue Sep 13 09:57:07 2016 -0700

----------------------------------------------------------------------
 src/tests/hierarchical_allocator_tests.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/f833169b/src/tests/hierarchical_allocator_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/hierarchical_allocator_tests.cpp 
b/src/tests/hierarchical_allocator_tests.cpp
index a2c0360..7705de9 100644
--- a/src/tests/hierarchical_allocator_tests.cpp
+++ b/src/tests/hierarchical_allocator_tests.cpp
@@ -3268,7 +3268,7 @@ TEST_F(HierarchicalAllocatorTest, UpdateWeight)
   // role2 share = 0
   //   framework2 share = 0
 
-  ASSERT_EQ(allocation.get().frameworkId, framework1.id());
+  ASSERT_EQ(framework1.id(), allocation.get().frameworkId);
   ASSERT_EQ(6u, allocation.get().resources.size());
   EXPECT_EQ(Resources::parse(TOTAL_RESOURCES).get(),
             Resources::sum(allocation.get().resources));

Reply via email to