Repository: mesos Updated Branches: refs/heads/master b1570606a -> 38af943ad
Added support/ to the list of the linted directories. By adding the support directory to 'mesos-style.py', we make sure that all our support scripts follow the same coding style that the rest of our Python codebase uses. We also added invalid-name to 'pylint.config' as all the Python files in support/ use dashes instead of underscores and we also added 'file-ignored' as we do not lint 'support/post-reviews.py' yet. Review: https://reviews.apache.org/r/62788/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/38af943a Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/38af943a Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/38af943a Branch: refs/heads/master Commit: 38af943ad6a2f8e7a47148ab6637692978545500 Parents: b157060 Author: Armand Grillet <agril...@mesosphere.io> Authored: Thu Oct 5 16:03:51 2017 +0200 Committer: Kevin Klues <klue...@gmail.com> Committed: Thu Oct 5 16:03:51 2017 +0200 ---------------------------------------------------------------------- src/python/pylint.config | 2 +- support/mesos-style.py | 3 ++- support/post-reviews.py | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/38af943a/src/python/pylint.config ---------------------------------------------------------------------- diff --git a/src/python/pylint.config b/src/python/pylint.config index 9f0361d..f74f553 100644 --- a/src/python/pylint.config +++ b/src/python/pylint.config @@ -2,7 +2,7 @@ ignore=.git [MESSAGES CONTROL] -disable=I0011,no-self-use,fixme +disable=I0011,no-self-use,fixme,invalid-name,file-ignored [REPORTS] reports=no http://git-wip-us.apache.org/repos/asf/mesos/blob/38af943a/support/mesos-style.py ---------------------------------------------------------------------- diff --git a/support/mesos-style.py b/support/mesos-style.py index bab7f5e..b2fdac9 100755 --- a/support/mesos-style.py +++ b/support/mesos-style.py @@ -352,6 +352,7 @@ class PyLinter(LinterBase): python_dir = os.path.join('src', 'python') cli_dir = os.path.join(python_dir, 'cli_new') lib_dir = os.path.join(python_dir, 'lib') + support_dir = 'support' self.config = { 'bootstrap_dir': cli_dir, @@ -360,7 +361,7 @@ class PyLinter(LinterBase): 'pylint_cmd': os.path.join(cli_dir, '.virtualenv', 'bin', 'pylint') } - self.source_dirs = [cli_dir, lib_dir] + self.source_dirs = [cli_dir, lib_dir, support_dir] def run_lint(self, source_paths): """ http://git-wip-us.apache.org/repos/asf/mesos/blob/38af943a/support/post-reviews.py ---------------------------------------------------------------------- diff --git a/support/post-reviews.py b/support/post-reviews.py index 5ecde40..c937871 100755 --- a/support/post-reviews.py +++ b/support/post-reviews.py @@ -36,6 +36,7 @@ $ cd /path/to/mesos $ [ do some work on your branch off of master, make commit(s) ] $ ./support/post-reviews.py """ +# pylint: skip-file import argparse import atexit
