Repository: mesos Updated Branches: refs/heads/master 5f53ddc99 -> 705bf1dfa
Marked volume/block creation and destroy operations as experimental. This patch marks the `CREATE_VOLUME`, `DESTROY_VOLUME`, `CREATE_BLOCK` and `DESTROY_BLOCK` as experimental APIs. It also unifies the way we mark experimental APIs. Review: https://reviews.apache.org/r/66616/ Project: http://git-wip-us.apache.org/repos/asf/mesos/repo Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/cbb947d5 Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/cbb947d5 Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/cbb947d5 Branch: refs/heads/master Commit: cbb947d50adeb1d76768910367cd973712b06583 Parents: 5f53ddc Author: Chun-Hung Hsiao <chhs...@apache.org> Authored: Tue Apr 17 18:38:38 2018 -0700 Committer: Chun-Hung Hsiao <chhs...@mesosphere.io> Committed: Tue Apr 17 18:38:38 2018 -0700 ---------------------------------------------------------------------- include/mesos/mesos.proto | 22 +++++++++++++++------- include/mesos/v1/mesos.proto | 22 +++++++++++++++------- 2 files changed, 30 insertions(+), 14 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/mesos/blob/cbb947d5/include/mesos/mesos.proto ---------------------------------------------------------------------- diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto index a3ee005..d480ec4 100644 --- a/include/mesos/mesos.proto +++ b/include/mesos/mesos.proto @@ -419,7 +419,7 @@ message FrameworkInfo { * specifying one of the optional fields. Specifying more than one type * is an error. * - * NOTE: This API is unstable and the related feature is experimental. + * NOTE: This API is subject to change and the related feature is experimental. */ message CheckInfo { enum Type { @@ -1919,10 +1919,10 @@ message Offer { UNRESERVE = 3; CREATE = 4; DESTROY = 5; - CREATE_VOLUME = 7; - DESTROY_VOLUME = 8; - CREATE_BLOCK = 9; - DESTROY_BLOCK = 10; + CREATE_VOLUME = 7; // EXPERIMENTAL. + DESTROY_VOLUME = 8; // EXPERIMENTAL. + CREATE_BLOCK = 9; // EXPERIMENTAL. + DESTROY_BLOCK = 10; // EXPERIMENTAL. } // TODO(vinod): Deprecate this in favor of `LaunchGroup` below. @@ -1959,19 +1959,27 @@ message Offer { repeated Resource volumes = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message CreateVolume { required Resource source = 1; required Resource.DiskInfo.Source.Type target_type = 2; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message DestroyVolume { required Resource volume = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message CreateBlock { required Resource source = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message DestroyBlock { required Resource block = 1; } @@ -1981,7 +1989,7 @@ message Offer { // NOTE: The `id` field will allow frameworks to indicate that they wish to // receive feedback about an operation. Since this feature is not yet // implemented, the `id` field should NOT be set at present. See MESOS-8054. - optional OperationID id = 12; // Experimental. + optional OperationID id = 12; // EXPERIMENTAL. optional Launch launch = 2; optional LaunchGroup launch_group = 7; @@ -2334,7 +2342,7 @@ message OperationStatus { * (e.g., the check timed out), these fields must contain empty messages, i.e., * `exit_code` or `status_code` will be unset. * -* NOTE: This API is unstable and the related feature is experimental. +* NOTE: This API is subject to change and the related feature is experimental. */ message CheckStatusInfo { message Command { http://git-wip-us.apache.org/repos/asf/mesos/blob/cbb947d5/include/mesos/v1/mesos.proto ---------------------------------------------------------------------- diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto index 26fc57e..775c7eb 100644 --- a/include/mesos/v1/mesos.proto +++ b/include/mesos/v1/mesos.proto @@ -417,7 +417,7 @@ message FrameworkInfo { * specifying one of the optional fields. Specifying more than one type * is an error. * - * NOTE: This API is unstable and the related feature is experimental. + * NOTE: This API is subject to change and the related feature is experimental. */ message CheckInfo { enum Type { @@ -1911,10 +1911,10 @@ message Offer { UNRESERVE = 3; CREATE = 4; DESTROY = 5; - CREATE_VOLUME = 7; - DESTROY_VOLUME = 8; - CREATE_BLOCK = 9; - DESTROY_BLOCK = 10; + CREATE_VOLUME = 7; // EXPERIMENTAL. + DESTROY_VOLUME = 8; // EXPERIMENTAL. + CREATE_BLOCK = 9; // EXPERIMENTAL. + DESTROY_BLOCK = 10; // EXPERIMENTAL. } // TODO(vinod): Deprecate this in favor of `LaunchGroup` below. @@ -1951,19 +1951,27 @@ message Offer { repeated Resource volumes = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message CreateVolume { required Resource source = 1; required Resource.DiskInfo.Source.Type target_type = 2; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message DestroyVolume { required Resource volume = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message CreateBlock { required Resource source = 1; } + // NOTE: For the time being, this API is subject to change and the related + // feature is experimental. message DestroyBlock { required Resource block = 1; } @@ -1973,7 +1981,7 @@ message Offer { // NOTE: The `id` field will allow frameworks to indicate that they wish to // receive feedback about an operation. Since this feature is not yet // implemented, the `id` field should NOT be set at present. See MESOS-8054. - optional OperationID id = 12; // Experimental. + optional OperationID id = 12; // EXPERIMENTAL. optional Launch launch = 2; optional LaunchGroup launch_group = 7; @@ -2326,7 +2334,7 @@ message OperationStatus { * (e.g., the check timed out), these fields must contain empty messages, i.e., * `exit_code` or `status_code` will be unset. * -* NOTE: This API is unstable and the related feature is experimental. +* NOTE: This API is subject to change and the related feature is experimental. */ message CheckStatusInfo { message Command {
