nikrao commented on issue #7390: adding ranking metrics (precision/recall) at position K. URL: https://github.com/apache/incubator-mxnet/pull/7390#issuecomment-328232367 done On Fri, Sep 8, 2017 at 3:44 PM, Haibin Lin <notificati...@github.com> wrote: > *@eric-haibin-lin* requested changes on this pull request. > > Why did you update all the submodules(nnvm, mshadow, dmlc-core)? Can you > revert these changes?? > e.g. > > cd nnvm > git checkout [the-original-nnvm-commit] > cd .. > git add nnvm > > ------------------------------ > > In python/mxnet/metric.py > <https://github.com/apache/incubator-mxnet/pull/7390#discussion_r137904015> > : > > > @@ -569,6 +569,161 @@ def update(self, labels, preds): > self.num_inst += 1 > > > +def truePositives(label): > > please rename to true_positives > > ? > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-mxnet/pull/7390#pullrequestreview-61639096>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ASlOLCgIqL8Mk8WkZyP_0eXyhV63RCWvks5sgcM4gaJpZM4OxWiq> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
