cswiercz commented on issue #7781: Implement Khatri-Rao operator URL: https://github.com/apache/incubator-mxnet/pull/7781#issuecomment-328583995 > I am not sure about the row_wise flag. The khatri-rao is a column-wise kronecker product, and the row-wise would also refer to the kronecker product, not khatri-rao.. Would it be clearer to have khatri_rao and maybe row_wise_kronecker (long name but unambiguous?) Yeah, I wasn't so sure about the flag. Having a separate operator sounds like a better idea. Plus it would clean up the code a bit. For consistency maybe: * `khatri_rao()` * `column_wise_kronecker()` *(alias to `khatri_rao`)* * `row_wise_kronecker()` Thoughts from anyone who is interested? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
