[GitHub] [incubator-mxnet] ptrendx commented on a change in pull request #16398: Aggregated adamw update

[GitBox]

ptrendx commented on a change in pull request #16398: Aggregated adamw update
URL: https://github.com/apache/incubator-mxnet/pull/16398#discussion_r332776281
 
 

 ##########
 File path: src/operator/contrib/adamw-inl.h
 ##########
 @@ -151,7 +135,7 @@ struct MPAdamWUpdate {
                const std::vector<TBlob> &outputs,
                const float rescale_grad) {
     using namespace mxnet_op;
-    AdamWParam param = nnvm::get<AdamWParam>(attrs.parsed);
+    const auto &param = nnvm::get<AdamWParam>(attrs.parsed);
 
 Review comment:
   I understand, but inside a single file we should try to make it consistent 
:-).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services