anirudh2290 commented on a change in pull request #16476: added large tensor support for add_n and tests for more ops URL: https://github.com/apache/incubator-mxnet/pull/16476#discussion_r335781449
########## File path: src/operator/tensor/elemwise_sum.h ########## @@ -64,7 +64,7 @@ void ElementWiseSumCompute_(const nnvm::NodeAttrs& attrs, size_t size = in_data.size(); Stream<xpu> *s = ctx.get_stream<xpu>(); DType* out_dptr = out_data[0].dptr<DType>(); - int out_size = static_cast<int>((out_data[0].Size() + DataType<DType>::kLanes - 1) + index_t out_size = static_cast<index_t>((out_data[0].Size() + DataType<DType>::kLanes - 1) Review comment: index_t with large tensor off is int32_t correct ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
