samskalicky commented on issue #15921: dynamic custom operator support URL: https://github.com/apache/incubator-mxnet/pull/15921#issuecomment-543570416 Thanks @wkcn, i ran into some flaky test failures and had to push another empty commit: ``` ===================================================================== FAIL: test_quantization_mkldnn.test_requantize_int32_to_int8 ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/local/lib/python3.5/dist-packages/nose/case.py", line 198, in runTest self.test(*self.arg) File "/usr/local/lib/python3.5/dist-packages/nose/util.py", line 620, in newfunc return func(*arg, **kw) File "/work/mxnet/tests/python/mkl/../unittest/common.py", line 177, in test_new orig_test(*args, **kwargs) File "/work/mxnet/tests/python/mkl/../quantization/test_quantization.py", line 186, in test_requantize_int32_to_int8 check_requantize_with_symbol((3, 4, 10, 10)) File "/work/mxnet/tests/python/mkl/../quantization/test_quantization.py", line 181, in check_requantize_with_symbol assert_almost_equal(qdata_int8.asnumpy(), qdata_int8_np) File "/work/mxnet/python/mxnet/test_utils.py", line 624, in assert_almost_equal raise AssertionError(msg) AssertionError: Items are not equal: Error 1562.500000 exceeds tolerance rtol=1.000000e-05, atol=1.000000e-20 (mismatch 0.083333%). Location of maximum error: (2, 0, 9, 8), a=63.00000000, b=64.00000000 ACTUAL: array([[[[ 106, 17, -56, ..., 88, -9, -38], [ 107, -120, -49, ..., -78, 81, 93], [-100, -90, -17, ..., 84, 49, -118],... DESIRED: array([[[[ 106, 17, -56, ..., 88, -9, -38], [ 107, -120, -49, ..., -78, 81, 93], [-100, -90, -17, ..., 84, 49, -118],... -------------------- >> begin captured stdout << --------------------- *** Maximum errors for vector of size 1200: rtol=1e-05, atol=1e-20 1: Error 1562.500000 Location of error: (2, 0, 9, 8), a=63.00000000, b=64.00000000 ====================================================================== FAIL: test_operator_gpu.test_fast_lars ---------------------------------------------------------------------- Traceback (most recent call last): File "C:\Python37\lib\site-packages\nose\case.py", line 198, in runTest self.test(*self.arg) File "C:\jenkins_slave\workspace\ut-python-gpu\tests\python\gpu\../unittest\common.py", line 177, in test_new orig_test(*args, **kwargs) File "C:\jenkins_slave\workspace\ut-python-gpu\tests\python\gpu\test_operator_gpu.py", line 328, in test_fast_lars check_fast_lars(w_dtype, g_dtype, shapes, ctx, tol1, tol2) File "C:\jenkins_slave\workspace\ut-python-gpu\tests\python\gpu\test_operator_gpu.py", line 310, in check_fast_lars assert_almost_equal(ref_new_lrs.asnumpy(), mx_new_lrs.asnumpy(), atol=tol2, rtol=tol2) File "C:\jenkins_slave\workspace\ut-python-gpu\windows_package\python\mxnet\test_utils.py", line 624, in assert_almost_equal raise AssertionError(msg) AssertionError: Items are not equal: Error 2.844314 exceeds tolerance rtol=1.000000e-06, atol=1.000000e-06 (mismatch 1.724138%). Location of maximum error: (33,), a=0.01896909, b=0.01897199 ACTUAL: array([0.00013492, 0.00045911, 0.00021266, ..., 0.00068631, 0.0002449 , 0.00085557], dtype=float32) DESIRED: array([0.00013493, 0.00045911, 0.00021266, ..., 0.00068631, 0.0002449 , 0.00085556], dtype=float32) -------------------- >> begin captured stdout << --------------------- *** Maximum errors for vector of size 58: rtol=1e-06, atol=1e-06 1: Error 2.844314 Location of error: (33,), a=0.01896909, b=0.01897199 ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
