marcoabreu commented on a change in pull request #16570: [WIP]Showing proper
error message when an attempt is made to create large tensor but MXNet is not
built with it
URL: https://github.com/apache/incubator-mxnet/pull/16570#discussion_r339134928
##########
File path: src/operator/tensor/init_op.h
##########
@@ -272,10 +272,22 @@ inline bool InitShape(const nnvm::NodeAttrs& attrs,
CHECK_EQ(in_attrs->size(), 0U);
CHECK_EQ(out_attrs->size(), 1U);
mxnet::TShape param_shape = param.shape;
+ if (shape_is_known(param_shape) &&
!features::is_enabled(features::INT64_TENSOR_SIZE)) {
Review comment:
I personally prefer that way - looks cleaner :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
