artor1os opened a new pull request #16720: [Numpy] Implement numpy operator 'average' URL: https://github.com/apache/incubator-mxnet/pull/16720 Add tests Implement returned Implement none weights returned Replace reduce implementation with workspace version Temp space can be requested only once. Use FNumVisibleOutputs attribute, always return sum of weights Fix bug Fix GPU bug Fix GPU bug ## Description ## Implement the numpy operator 'average' https://numpy.org/devdocs/reference/generated/numpy.average.html ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [ ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] op average, tests, (and when applicable, API doc) ## Comments ## - does not guarantee the same behavior with numpy when given float32 dtype and overflow occurs - a and weights must be the same dtype
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
