marcoabreu commented on a change in pull request #16699: Mixed data type binary ops URL: https://github.com/apache/incubator-mxnet/pull/16699#discussion_r342319668
########## File path: src/operator/mshadow_op.h ########## @@ -194,6 +194,100 @@ MXNET_BINARY_MATH_OP_NC(right, b); MXNET_BINARY_MATH_OP_NC(mul, a * b); +#ifndef _WIN32 Review comment: I'm well aware of the unit tests passing on windows, thanks for the helpful hint. Still, can you elaborate which part exactly is not supported by the windows compiler? Basically the whole PR is excluding Windows and that seems off. Having an entirely different implementation for a different OS is not something I see regularly, so I'm eager to learn ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
