apeforest commented on a change in pull request #16184: Add large tensor nightly tests for MKL-DNN operators URL: https://github.com/apache/incubator-mxnet/pull/16184#discussion_r342922763
########## File path: tests/nightly/test_large_array.py ########## @@ -782,8 +801,30 @@ def test_activation(): # in future, we could test if mean, var of output # matches target output's mean, var def test_batchnorm(): - shape = (LARGE_X, SMALL_Y) + def get_ref_mean_var(data, running_mean, running_var, eps, use_global_status=True): Review comment: Why use ndarray to get_ref_mean_var? Wouldn't it be simpler and more correct to just implement it using numpy? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
