anirudh2290 commented on a change in pull request #16748: Fix SliceChannel Type
inference
URL: https://github.com/apache/incubator-mxnet/pull/16748#discussion_r343786780
##########
File path: tests/python/gpu/test_contrib_amp.py
##########
@@ -475,6 +475,15 @@ def test_fp16_casting():
exe = final_res.simple_bind(ctx=mx.gpu(), data=(1, 2), data2=(1, 2))
assert exe.arg_arrays[0].dtype == np.float16
+ # Check for symbol which has slice channel
+ data = mx.sym.var("data")
+ data2 = mx.sym.var("data2")
+ data._set_attr(__dtype__="-1")
+ data2._set_attr(__dtype__="-1")
+ concat_res = mx.sym.concat(data, data2)
+ out = mx.sym.split(concat_res, axis=1, num_outputs=2)
+ final_res = amp.convert_symbol(out)
Review comment:
no, this was earlier failing in the convert_symbol call before this change.
Just need to check if convert_symbol completes successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
