hzfan commented on a change in pull request #16800: [WIP][DO NOT MERGE][Numpy]
np.linalg.det and np.linalg.slogdet
URL: https://github.com/apache/incubator-mxnet/pull/16800#discussion_r346114041
##########
File path: tests/python/unittest/test_numpy_op.py
##########
@@ -3222,6 +3222,94 @@ def check_inv(A_inv, data_np):
check_inv(A_inv, data_np)
+def test_np_linalg_det():
+ class TestDet(HybridBlock):
+ def __init__(self):
+ super(TestDet, self).__init__()
+
+ def hybrid_forward(self, F, a):
+ return F.np.linalg.det(a)
+
+ # test non zero size input
+ tensor_shapes = [
Review comment:
Could you add additional tests to cover 0-size cases? like (0, 2, 2)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
