perdasilva edited a comment on issue #16787: [CD] PyPI pipeline fix URL: https://github.com/apache/incubator-mxnet/pull/16787#issuecomment-554515789 Hey @marcoabreu I didn't quite get it. I've added some changes to disable this rule for that specific line. If I understood you correctly, you wanted me to run pylint with python2? Seems to work with python2 (without my changes): ``` python2 -m pylint --rcfile=ci/other/pylintrc --ignore-patterns=".*\.so$,.*\.dll$,.*\.dylib$" python/mxnet/base.py Using config file /Users/silvaper/repositories/perdasilva/incubator-mxnet/ci/other/pylintrc ------------------------------------ Your code has been rated at 10.00/10 ``` (python3 just to sanity check that the changes weren't there =D) ``` python3 -m pylint --rcfile=ci/other/pylintrc --ignore-patterns=".*\.so$,.*\.dll$,.*\.dylib$" python/mxnet/base.py ************* Module mxnet.base python/mxnet/base.py:92:35: E0602: Undefined variable 'unicode' (undefined-variable) ------------------------------------------------------------------- Your code has been rated at 9.88/10 (previous run: 10.00/10, -0.12) ``` With my changes, it seems to work with both: ``` python2 -m pylint --rcfile=ci/other/pylintrc --ignore-patterns=".*\.so$,.*\.dll$,.*\.dylib$" python/mxnet/base.py Using config file /Users/silvaper/repositories/perdasilva/incubator-mxnet/ci/other/pylintrc -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ``` ``` python3 -m pylint --rcfile=ci/other/pylintrc --ignore-patterns=".*\.so$,.*\.dll$,.*\.dylib$" python/mxnet/base.py -------------------------------------------------------------------- Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00) ``` Let's see if the sanity check agrees ^^
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
