DickJC123 opened a new pull request #16838: USE_NVRTC -> ENABLE_CUDA_RTC to fix maven build. Add compile-guard to fusion. URL: https://github.com/apache/incubator-mxnet/pull/16838 This PR fixes the maven build issue https://github.com/apache/incubator-mxnet/issues/16765 reported by @zachgk and first seen with PR https://github.com/apache/incubator-mxnet/pull/15167. The fix involved- 1. Renaming the build flag used by maven (namely `USE_NVRTC`) to the name used by the pip builds (`ENABLE_CUDA_RTC`). The Makefile currently looks at ENABLE_CUDA_RTC (not USE_NVRTC) and in response sets the compile flag MXNET_ENABLE_CUDA_RTC=1 and adds `-lcuda -lnvrtc` to the LDFLAGS. It was the absence of these ld flags when creating im2rec that caused the issue filed. 2. Adding compile guards to the newly-introduced files ./src/operator/fusion/* in a form similar to those that protect ./src/common/rtc.cc. Now both cuda runtime-compilation facilities are included into the build (or not) based on MXNET_ENABLE_CUDA_RTC. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [ X] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [X ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
