haojin2 commented on a change in pull request #16862: Op Unravel_index PR
[Numpy]
URL: https://github.com/apache/incubator-mxnet/pull/16862#discussion_r348997859
##########
File path: python/mxnet/numpy/multiarray.py
##########
@@ -57,7 +57,7 @@
'blackman', 'flip', 'around', 'arctan2', 'hypot', 'bitwise_xor',
'rad2deg', 'deg2rad', 'unique', 'lcm',
'tril', 'identity', 'take', 'ldexp', 'vdot', 'inner', 'outer',
'equal', 'not_equal', 'greater', 'less',
'greater_equal', 'less_equal', 'hsplit', 'rot90', 'einsum',
'true_divide', 'nonzero', 'shares_memory',
- 'may_share_memory', 'diff', 'resize', 'nan_to_num', 'where']
+ 'may_share_memory', 'diff', 'resize', 'nan_to_num', 'where',
'unravel_index']
Review comment:
Move `unravel_index` to the position after `ravel` is better, also do this
for the definition of the function. also do this for all other python wrappers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
