wkcn commented on a change in pull request #15686: Fix the problem in printing 
feature in c++ API examples : feature_extract
URL: https://github.com/apache/incubator-mxnet/pull/15686#discussion_r308541801
 
 

 ##########
 File path: cpp-package/example/feature_extract/feature_extract.cpp
 ##########
 @@ -106,6 +106,7 @@ class FeatureExtractor {
     /*print out the features*/
     auto array = executor->outputs[0].Copy(Context(kCPU, 0));
     NDArray::WaitAll();
+    array = array.Reshape({2, 1024});
 
 Review comment:
   Thank you for the fix!
   
   What is the meaning of `2` in Reshape?
   If `2` is the batch size, I think replacing it with `0`  may be better. 
`array = array.Reshape({0, 1024});`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to