haojin2 commented on a change in pull request #16913: [numpy] add op linalg solve URL: https://github.com/apache/incubator-mxnet/pull/16913#discussion_r354585357
########## File path: src/operator/numpy/linalg/np_solve.cc ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * Copyright (c) 2019 by Contributors + * \file np_solve.cc + * \brief CPU implementation placeholder of Solve Operator + */ +#include <mxnet/operator_util.h> +#include <vector> +#include "../../mshadow_op.h" +#include "../../mxnet_op.h" +#include "../../operator_common.h" +#include "../../elemwise_op_common.h" + +#include "./np_solve-inl.h" + +namespace mxnet { +namespace op { + +inline bool SolveOpShape(const nnvm::NodeAttrs &attrs, + std::vector<mxnet::TShape> *in_attrs, + std::vector<mxnet::TShape> *out_attrs) { + CHECK_EQ(in_attrs->size(), 2U); + CHECK_EQ(out_attrs->size(), 1U); + const mxnet::TShape& in_a_shape = (*in_attrs)[0]; + const mxnet::TShape& in_b_shape = (*in_attrs)[1]; + if (!ndim_is_known(in_a_shape)) { return false; } + int in_a_ndim = in_a_shape.ndim(), in_b_ndim = in_b_shape.ndim(); + + CHECK_GE(in_a_ndim, 2) + << "Array must be at least two-dimensional"; + CHECK_EQ(in_a_shape[in_a_ndim - 2], in_a_shape[in_a_ndim - 1]) + << "Input A's last two dimension must be equal"; + + if (in_a_ndim == in_b_ndim + 1) { + CHECK_EQ(in_a_shape[in_a_ndim - 1], in_b_shape[in_b_ndim - 1]) + << "Input A's and B's last dimension must be equal"; + } else if (in_a_ndim == in_b_ndim) { + CHECK_EQ(in_a_shape[in_a_ndim - 1], in_b_shape[in_b_ndim - 2]) + << "Input A's and B's last second dimension must be equal"; + } else { + dmlc::LogMessageFatal(__FILE__, __LINE__).stream() << "A's and B's dimensions don't match"; + } + for (int i = 0; i < in_a_ndim - 2; ++i) { + CHECK_EQ(in_a_shape[i], in_b_shape[i]) << "A's and B's dimensions don't match"; + } + + SHAPE_ASSIGN_CHECK(*out_attrs, 0, in_b_shape); + return !mxnet::op::shape_is_none(in_b_shape) && !mxnet::op::shape_is_none(out_attrs->at(0)); +} + +inline bool SolveOpType(const nnvm::NodeAttrs& attrs, + std::vector<int>* in_attrs, + std::vector<int>* out_attrs) { + CHECK_EQ(in_attrs->size(), 2U); + CHECK_EQ(out_attrs->size(), 1U); + int a_type = in_attrs->at(0); + int b_type = in_attrs->at(1); + // unsupport float16 + CHECK_NE(a_type, mshadow::kFloat16) + << "array type float16 is unsupported in linalg"; + CHECK_NE(b_type, mshadow::kFloat16) + << "array type float16 is unsupported in linalg"; + if (mshadow::kFloat32 == a_type && mshadow::kFloat32 == b_type) { + TYPE_ASSIGN_CHECK(*out_attrs, 0, in_attrs->at(1)); + } else { + TYPE_ASSIGN_CHECK(*out_attrs, 0, mshadow::kFloat64); + } + return out_attrs->at(0) != -1; +} + +NNVM_REGISTER_OP(_npi_solve) +.describe(R"code()code" ADD_FILELINE) +.set_num_inputs(2) +.set_num_outputs(1) +.set_attr<nnvm::FListInputNames>("FListInputNames", [](const NodeAttrs& attrs){ + return std::vector<std::string>{"A", "B"}; }) +.set_attr<mxnet::FInferShape>("FInferShape", SolveOpShape) +.set_attr<nnvm::FInferType>("FInferType", SolveOpType) +.set_attr<FResourceRequest>("FResourceRequest", [](const NodeAttrs& attrs){ + return std::vector<ResourceRequest>{ResourceRequest::kTempSpace}; }) +.set_attr<THasDeterministicOutput>("THasDeterministicOutput", true) +.set_attr<FCompute>("FCompute<cpu>", LaOpForwardSolve<cpu, 2, 2, 2, 1, solve>) +.set_attr<nnvm::FGradient>("FGradient", ElemwiseGradUseInOut{"_backward_npi_solve"}) +.add_argument("A", "NDArray-or-Symbol", "Tensor of square matrix") +.add_argument("B", "NDArray-or-Symbol", "Tensor of right side vector"); + +NNVM_REGISTER_OP(_backward_npi_solve) +.set_num_inputs(4) +.set_num_outputs(2) +.set_attr<FResourceRequest>("FResourceRequest", [](const NodeAttrs& ){ + return std::vector<ResourceRequest>{ResourceRequest::kTempSpace}; }) Review comment: ```c++ .set_attr<FResourceRequest>("FResourceRequest", [](const NodeAttrs& ){ return std::vector<ResourceRequest>{ResourceRequest::kTempSpace}; }) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
