liuzh91 commented on a change in pull request #16982: Add support of plug and
play fit_batch and evaluate_batch
URL: https://github.com/apache/incubator-mxnet/pull/16982#discussion_r354688027
##########
File path: python/mxnet/gluon/contrib/estimator/estimator.py
##########
@@ -269,9 +271,14 @@ def evaluate(self,
for metric in val_metrics:
metric.reset()
+ estimator_ref = self
for _, batch in enumerate(val_data):
- self.evaluate_batch(batch, val_metrics, batch_axis)
+ if self.estimator_model is None:
+ self.evaluate_batch(batch, val_metrics, batch_axis)
Review comment:
I have removed the duplicate code for `fit_batch` and `evaluate_batch`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
