leezu commented on a change in pull request #17031: Use CMake standard library to handle CUDA URL: https://github.com/apache/incubator-mxnet/pull/17031#discussion_r356965291
########## File path: 3rdparty/mshadow/CMakeLists.txt ########## @@ -1,4 +1,4 @@ -cmake_minimum_required(VERSION 2.8.7) +cmake_minimum_required(VERSION 3.0.2) Review comment: This file only adds the lint target for mshadow. Let's just keep it unchanged for now thanks to > CMake keeps policy settings on a stack, so changes made by the cmake_policy command affect only the top of the stack. A new entry on the policy stack is managed automatically for each subdirectory to protect its parents and siblings. Or would there be a problem linting the cuda code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
