liuzh91 commented on issue #17051: fix parameter names in the estimator api
URL: https://github.com/apache/incubator-mxnet/pull/17051#issuecomment-564864220
 
 
   @ptrendx @leezu @szha Thanks for the reply. I understand the risk of 
changing parameter names may break existing api. But the parameters 
`evaluation_loss` `eval_net` were just introduced last week, there have not yet 
much dependencies on these parameters. 
   
   Anyway it is ok to merge this fix into a later release. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to