yzhliu commented on a change in pull request #17214: [tvmop] support cuda
multi-arch compilation
URL: https://github.com/apache/incubator-mxnet/pull/17214#discussion_r363182656
##########
File path: CMakeLists.txt
##########
@@ -840,7 +841,7 @@ install(TARGETS ${MXNET_INSTALL_TARGETS}
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/dlpack/include/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/dmlc-core/include/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR})
-if(USE_MKLDNN)
+if(INSTALL_MKLDNN)
Review comment:
actually I need something opposite of `PARENT_SCOPE`
```cmake
option(USE_MKLDNN ON)
if(USE_MKLDNN)
...
endif()
if(USE_TVM_OP)
include(cmake/BuildTVM.cmake) <- in BuildTVM.cmake I set(USE_MKLDNN OFF)
...
endif()
if(USE_MKLDNN) <- here it is OFF, while should be ON
...
endif()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
