larroy commented on a change in pull request #16654: Multithreaded Inference 
Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r364407636
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -1212,6 +1230,8 @@ unittest_ubuntu_cpugpu_perl() {
 
 unittest_cpp() {
     set -ex
+    export PYTHONPATH=./python/
+    python3 -c "import mxnet as mx; 
mx.test_utils.download_model(\"imagenet1k-resnet-18\"); 
mx.test_utils.download_model(\"imagenet1k-resnet-152\"); 
mx.test_utils.download_model(\"imagenet1k-resnet-50\");"
 
 Review comment:
   I don't like this inlined python very much, it's also duplicated code below, 
it could be factored out into a utility script or a function. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to