ChaiBapchya opened a new pull request #17297: Fix NCCL Cmake autodetect issue
URL: https://github.com/apache/incubator-mxnet/pull/17297
 
 
   ## Description ##
   Fixes https://github.com/apache/incubator-mxnet/issues/17239
   
   ## Checklist ##
   ### Essentials ###
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] Code is well-documented: 
   - [ ] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   modified:   cmake/Modules/FindNCCL.cmake
   
   ## Test ##
   Tested with following command
   ```
   cmake -GNinja -DUSE_CUDA=ON -DCMAKE_CUDA_COMPILER_LAUNCHER=ccache 
-DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache 
-DCMAKE_BUILD_TYPE=Release -DUSE_CUDNN=ON -DUSE_NCCL=ON ..
   ```
   
   Without this branch, it failed with NCCL not found
   ```
   Could NOT find NCCL (missing: NCCL_INCLUDE_DIRS NCCL_LIBRARIES)
   CMake Warning at CMakeLists.txt:636 (message):
     Could not find NCCL libraries
   ```
   
   With this PR, it passes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to