rongzha1 commented on a change in pull request #17170: add mkldnn softmax
backward
URL: https://github.com/apache/incubator-mxnet/pull/17170#discussion_r366658974
##########
File path: src/operator/nn/mkldnn/mkldnn_softmax.cc
##########
@@ -131,6 +143,80 @@ void MKLDNNSoftmaxForward(const nnvm::NodeAttrs& attrs,
stream->Submit();
}
+class MKLDNNSoftmaxBwd {
+ public:
+ mkldnn::softmax_backward::primitive_desc pd;
+
+ MKLDNNSoftmaxBwd(const mkldnn::memory &diff_mem,
+ const mkldnn::memory &data_mem,
+ const int axis,
+ const mkldnn::softmax_forward::primitive_desc &hint_fwd_pd)
:
+ pd(GetSoftmaxBwdPd(diff_mem, data_mem, axis,
hint_fwd_pd)) {
+ bwd_ = std::make_shared<mkldnn::softmax_backward>(pd);
+ }
+
+ const mkldnn::softmax_backward &GetBwd() const {
+ return *bwd_;
+ }
+
+ private:
+ std::shared_ptr<mkldnn::softmax_backward> bwd_;
+};
+
+typedef ParamOpSign<SoftmaxParam> MKLDNNSoftmaxSignature;
Review comment:
exactly same, add extra one when rebase, will remove this line Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
