ChaiBapchya commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r367577696
########## File path: cmake/Modules/FindNCCL.cmake ########## @@ -33,6 +33,23 @@ set(NCCL_ROOT_DIR "" CACHE PATH "Folder contains NVIDIA NCCL") +# first check in the /usr/local/cuda before other paths Review comment: > If there is some nccl.h at /usr/local/cuda but the user specifies NCCL_ROOT_DIR=/home/ubuntu/myversionofnccl, the /usr/local/cuda is wrongly used? Or do I misunderstand the doc? I agree, since "search" will not be repeated until var is set, it makes sense to assume whatever location is found first is final. So in that case first check has to be env var and second for default. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
