roywei edited a comment on issue #17351: [LICENSE] Update ps-lite LICENSE URL: https://github.com/apache/incubator-mxnet/pull/17351#issuecomment-575736054 Hi @leezu , for 3rd party source files, we do not need to include the ASF license header, as it's not developed by ASF(Note the ASF license header is not the same as apache-2.0 license). We can depend on ps-lite as it's a permissive license (Apache 2.0). That specific file should already be covered by the apache-2.0 license, and we already acknowledged it in LICENSE file. So we just need to acknowledge additional copy right comes from ps-lite. I think the mentor may made a mistake about the unknown license part. From https://www.apache.org/legal/src-headers.html: > Do not add the standard Apache License header to the top of third-party source files. Our rat check already excluded 3rdparty directory. So we will only have problem if we added ASF header wrongly, any missing header will cause rat check to fail.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
