leezu commented on a change in pull request #17297: Fix NCCL Cmake autodetect
issue
URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r368082784
##########
File path: cmake/Modules/FindNCCL.cmake
##########
@@ -55,6 +67,23 @@ find_library(NCCL_LIBRARIES
$ENV{NCCL_DIR}/lib
)
+# if not found in any of the above paths, finally, check in the
/usr/local/cuda for UNIX systems
+if (UNIX)
Review comment:
A variable will be set to not found. The calling cmake module needs to check
that variable and error out if nccl is required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
