samskalicky commented on a change in pull request #15969: [WIP] Partitioning 
Gluon HybridBlocks
URL: https://github.com/apache/incubator-mxnet/pull/15969#discussion_r368208570
 
 

 ##########
 File path: python/mxnet/gluon/block.py
 ##########
 @@ -932,6 +932,9 @@ def _get_graph(self, *args):
 
     def _build_cache(self, *args):
         data, out = self._get_graph(*args)
+        if self._backend:
+            # To do: pass in all arguments
+            out = out.optimize_for(self._backend)
 
 Review comment:
   also pass `self.optargs` to `optimize_for` like:
   ```
   out = out.optimize_for(self._backend, **self.optargs)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to