eric-haibin-lin commented on a change in pull request #15124: [MXNET-1294]
Priority-based parameter propagation for improved data parallel training
throughput
URL: https://github.com/apache/incubator-mxnet/pull/15124#discussion_r368814411
##########
File path: python/mxnet/kvstore/kvstore.py
##########
@@ -104,8 +104,22 @@ def broadcast(self, key, value, out, priority=0):
[ 2. 2. 2.]]
"""
- self.init(key, value)
- self.pull(key, out=out, priority=priority)
+ cvkeys, cvals, use_str_keys = _ctype_key_value(key, value)
+ if out is not None:
+ cokeys, couts, _ = _ctype_key_value(key, out)
+ else:
+ cokeys = cvkeys
+ couts = cvals
+
+ if use_str_keys:
+ check_call(_LIB.MXKVStoreBroadcastEx(
+ self.handle, mx_uint(len(cvkeys)), cvkeys,
mx_uint(len(cokeys)), cokeys,
+ cvals, couts, ctypes.c_int(priority)))
+ else:
+ check_call(_LIB.MXKVStoreBroadcast(
+ self.handle, mx_uint(len(cvkeys)), cvkeys,
mx_uint(len(cokeys)), cokeys,
+ cvals, couts, ctypes.c_int(priority)))
+
Review comment:
Shall we also add tests to
https://github.com/apache/incubator-mxnet/blob/d9291e5ae0b3f757e781bf457bdff8b6a61b8c8d/ci/docker/runtime_functions.sh#L1373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
