roywei commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-577440334 Yes, agree we need a script and the exclude rules for rat-check need to be revisited. We should avoid bulk exclusion entire folder. Anything in the exclusion need to be manually checked for license and copyright compliance. It's quite tricky to translate the following rules to scripts. https://www.apache.org/legal/src-headers.html https://www.apache.org/legal/resolved.html Right now I can think of the following rules. Any suggestion is welcome. For our own source files: 1. files that has two license headers 2. files that has copy right statement, and not acknowledged in top level LICENSE file. (normal ASF contribution does not require specific copyright notice in source file) 3. files that has license header other than ASF license, and not acknowledged in top level LICENSE file. For 3rd party source files, it's more tricky and each dependency may come with files with several license and copy right. We may need to rely on some existing tools. https://github.com/nexB/scancode-toolkit
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
