eric-haibin-lin commented on a change in pull request #8294: NCCL integration
URL: https://github.com/apache/incubator-mxnet/pull/8294#discussion_r145023673
##########
File path: src/kvstore/kvstore_local.h
##########
@@ -256,14 +260,14 @@ class KVStoreLocal : public KVStore {
/**
* \brief group values on keys for pull
*/
- void GroupKVPairsPull(const std::vector<int>& keys,
- const std::vector<NDArray*>& values,
- std::vector<int> *uniq_keys,
- std::vector<std::vector<NDArray*>> *grouped_vals) {
+ virtual void GroupKVPairsPull(const std::vector<int>& keys,
Review comment:
Why is `virtual` added here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
