access2rohit commented on a change in pull request #17444: [Large Tensor] Add LT support for NN optimizers and 1 activation function URL: https://github.com/apache/incubator-mxnet/pull/17444#discussion_r371948206
########## File path: src/operator/optimizer_op-inl.h ########## @@ -1620,7 +1620,7 @@ struct LambUpdatePhaseTwoParam : public dmlc::Parameter<LambUpdatePhaseTwoParam> struct LambUpdatePhaseOneKernel { template<typename DType> - MSHADOW_XINLINE static void Map(int i, DType* out_data, + MSHADOW_XINLINE static void Map(index_t i, DType* out_data, Review comment: Damm.. i missed it ! Thanks for fixing ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services