[GitHub] [incubator-mxnet] ChaiBapchya commented on a change in pull request #17482: [OpPerf] Add Neural network loss ops

[GitBox]

ChaiBapchya commented on a change in pull request #17482: [OpPerf] Add Neural 
network loss ops
URL: https://github.com/apache/incubator-mxnet/pull/17482#discussion_r373736222
 
 

 ##########
 File path: benchmark/opperf/utils/profiler_utils.py
 ##########
 @@ -48,8 +48,8 @@ def _get_operator_profile(operator_name, 
operator_profile_results):
     # alias map : dictionary of the form {"alias" : "registered_name"}
     # allows to retrieve alias operator profile from the profiler results
     # TODO handling - "identity" : "_copy"
-    alias_map = {"broadcast_plus" : "broadcast_add", "broadcast_minus" : 
"broadcast_sub", "flatten" : "Flatten", "max_axis" : "max",
-                 "swapaxes" : "SwapAxis", "flip" : "reverse", "reshape" : 
"Reshape", "crop" : "slice", "sum_axis" : "sum", "min_axis" : "min"}
+    alias_map = {"broadcast_plus": "broadcast_add", "broadcast_minus": 
"broadcast_sub", "flatten": "Flatten", "max_axis": "max",
 
 Review comment:
   pep8 requires no space before ":"
   https://www.python.org/dev/peps/pep-0008/
   
   <img width="969" alt="Screen Shot 2020-01-31 at 4 07 34 PM" 
src="https://user-images.githubusercontent.com/10992635/73582846-e7c27580-4443-11ea-8a68-c3098c7e35cd.png";>
   <img width="963" alt="Screen Shot 2020-01-31 at 4 07 23 PM" 
src="https://user-images.githubusercontent.com/10992635/73582848-e85b0c00-4443-11ea-9126-f46ed8af4b1a.png";>
   
   Refer - http://pep8online.com/checkresult

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services