access2rohit commented on a change in pull request #16253: [OpPerf] Add Indexing ops URL: https://github.com/apache/incubator-mxnet/pull/16253#discussion_r374874119
########## File path: benchmark/opperf/utils/op_registry_utils.py ########## @@ -316,11 +318,37 @@ def get_all_rearrange_operators(): # Filter for Array Rearrange operators rearrange_mx_operators = {} - for op_name, op_params in mx_operators.items(): + for op_name, _ in mx_operators.items(): if op_name in rearrange_ops and op_name not in unique_ops: rearrange_mx_operators[op_name] = mx_operators[op_name] return rearrange_mx_operators + +def get_all_indexing_routines(): + """Gets all indexing routines registered with MXNet. + + Returns + ------- + {"operator_name": {"has_backward", "nd_op_handle", "params"}} + """ + # @ChaiBapchya unravel_index errors out on certain inputs Review comment: is this a TODO ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services