leezu commented on issue #17545: CMake GPU build broken by #16654
URL: 
https://github.com/apache/incubator-mxnet/issues/17545#issuecomment-583693582
 
 
   Root cause seems to be the change in preprocessor logic. Compare 
   
   
https://github.com/apache/incubator-mxnet/commit/b1e491182fa9c15da89f1b701778de3a1421811b#diff-ca9cfe7afd877e3f6a1601e9f9894ea1R233
   
   
https://github.com/apache/incubator-mxnet/commit/b1e491182fa9c15da89f1b701778de3a1421811b#diff-b7c9df82199fd093bf767c1635607088L170
   
   Another thing exposed by this PR is that the config.cmake should include 
`set(ENABLE_CUDA_RTC ON` instead of OFF. It's set off by default based on a 
misunderstanding on my side that this feature is not commonly used anymore.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to