eric-haibin-lin opened a new pull request #8345: Misc fixes for sparse distributed training URL: https://github.com/apache/incubator-mxnet/pull/8345 ## Description ## - As #8116 removes [wait_to_write](https://github.com/apache/incubator-mxnet/pull/8116/files#diff-0cd6fcb2cd941d4c4a829bb3d7ea3d63L274) when updating comm_buff, it's not safe to pass NDArray* to the callback for row_sparse_pull. Now changed to NDArray. - Removed the usage of `mshadow::range` in `FillDnsZerosRspImpl` since `mshadow::range` uses float to calculate the tensor shape and is inaccurate for large shapes. - Added unit test for pulling empty sparse weights - Removed wrong/misleading comments @bhavinthaker @madjam @rahul003 ## Checklist ## ### Essentials ### - [ ] Passed code style checking (`make lint`) - [ ] Changes are complete (i.e. I finished coding on this PR) - [ ] All changes have test coverage - [ ] For user-facing API changes, API doc string has been updated. - [ ] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Intersting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
