haojin2 commented on a change in pull request #17657: Add numpy_fallback
decorator
URL: https://github.com/apache/incubator-mxnet/pull/17657#discussion_r382876918
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -5087,7 +5087,7 @@ def _make_dl_managed_tensor(array):
return array(ndarray, dtype=ndarray.dtype)
if not ndarray.flags['C_CONTIGUOUS']:
- raise ValueError("Only c-contiguous arrays are supported for
zero-copy")
+ return array(ndarray, dtype=ndarray.dtype)
Review comment:
The same thing could actually be done in another way, I can catch this error
outside the function and handle accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
