access2rohit commented on a change in pull request #17632: [Large Tensor] Fixed
RNN op
URL: https://github.com/apache/incubator-mxnet/pull/17632#discussion_r383529334
##########
File path: src/operator/rnn-inl.h
##########
@@ -123,7 +123,7 @@ struct RNNParam : public dmlc::Parameter<RNNParam> {
};
inline int GetRnnParamSize(int num_layer,
- int input_size,
+ index_t input_size,
Review comment:
Are you sure you don't have to change size1, size2, proj_size and param_size:
https://github.com/apache/incubator-mxnet/pull/17632/files#diff-6dfdca409e69cc495f286170fe1e553eR143
-
https://github.com/apache/incubator-mxnet/pull/17632/files#diff-6dfdca409e69cc495f286170fe1e553eR152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
