ChaiBapchya commented on a change in pull request #17675: [Large Tensor] Fix
multi_lars op
URL: https://github.com/apache/incubator-mxnet/pull/17675#discussion_r383770871
##########
File path: tests/nightly/test_large_array.py
##########
@@ -467,6 +468,20 @@ def check_col2im():
assert res.shape[2] == 2
assert res.shape[3] == 2
assert res.shape[4] == 1
+
+ def check_multi_lars():
+ lrs = nd.random_normal(shape=(LARGE_TENSOR_SHAPE + 1, 1))
+ weights_sum_sq = nd.random_normal(shape=(LARGE_TENSOR_SHAPE + 1, 1))
+ grads_sum_sq = nd.random_normal(shape=(LARGE_TENSOR_SHAPE + 1, 1))
+ wds = nd.random_normal(shape=(LARGE_TENSOR_SHAPE + 1, 1))
+ eta = .1
+ eps = .9
+
+ out = nd.multi_lars(lrs=lrs, weights_sum_sq=weights_sum_sq,
grads_sum_sq=grads_sum_sq,
+ wds=wds, eta=eta, eps=eps)
+
Review comment:
shape assertions don't necessarily mean the NDArrays would be created right?
let's check for values as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
