HahTK commented on a change in pull request #17623: Dynamic subgraph compile
support
URL: https://github.com/apache/incubator-mxnet/pull/17623#discussion_r384223762
##########
File path: example/extensions/lib_subgraph/subgraph_lib.cc
##########
@@ -218,10 +218,27 @@ MXReturnValue mySupportedOps(std::string json,
MXReturnValue myReviewSubgraph(std::string json, int subraph_id, bool* accept,
std::unordered_map<std::string, std::string>&
options,
- std::unordered_map<std::string, std::string>&
attrs) {
+ std::unordered_map<std::string, std::string>&
attrs,
+ std::map<std::string, MXTensor>& args,
+ std::map<std::string, MXTensor>& aux) {
for (auto kv : options) {
std::cout << "option: " << kv.first << " ==> " << kv.second << std::endl;
}
+ for (auto kv : args) {
Review comment:
are we missing auxs here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
