zixuanweeei commented on a change in pull request #17632: [Large Tensor] Fixed
RNN op
URL: https://github.com/apache/incubator-mxnet/pull/17632#discussion_r386880227
##########
File path: src/operator/rnn-inl.h
##########
@@ -361,9 +361,9 @@ void RNNBackward(DType* ws,
DType* rs,
const int num_layers,
const int direction,
- const int seq_length,
- const int batch_size,
- const int input_size,
+ const index_t seq_length,
+ const index_t batch_size,
+ const index_t input_size,
Review comment:
Agree with keeping the signed `index_t` :100:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
