ptrendx opened a new pull request #17946: Change register_op_hook to take MXNet and Python types instead of C types URL: https://github.com/apache/incubator-mxnet/pull/17946 ## Description ## This PR changes the API of the Gluon's `register_op_hook` method to take the Python strings and MXNet NDArray instead of the C string and internal NDArrayHandle. Also it fixes a bug in the documentation (which previously said that the function should take 2 parameters, whereas in fact it takes 3). This change makes the `register_op_hook` much more user-friendly, especially for people not familiar with MXNet internals. @szha @eric-haibin-lin @anirudh2290 ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
