hzfan commented on a change in pull request #17866: [Numpy] Add ffi for np.sum,
np.std, np.var and np.average
URL: https://github.com/apache/incubator-mxnet/pull/17866#discussion_r401440022
##########
File path: python/mxnet/ndarray/numpy/_op.py
##########
@@ -1734,13 +1734,13 @@ def histogram(a, bins=10, range=None, normed=None,
weights=None, density=None):
if isinstance(bins, numeric_types):
if range is None:
raise NotImplementedError("automatic range is not supported
yet...")
- return _npi.histogram(a, bin_cnt=bins, range=range)
+ return _api_internal.histogram(a, None, bins, range)
Review comment:
`tuple(_api_internal.histogram(a, None, bins, range))` may be better.
Otherwise the `ADT` is directly returned to users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
