RuRo opened a new pull request #18054: Bump ONNX version to 1.5.0 URL: https://github.com/apache/incubator-mxnet/pull/18054 ## Description ## This is a WIP pull request for increasing the supported `ONNX` version from `1.3.0` to `1.5.0`. This change is motivated by the fact, that `ONNX v1.5.0` (opset 10) supports new operators, that should allow/simplify the implementation of some `mxnet -> ONNX` conversions, that are currently not implemented. List of potentially useful operators, which were not available in `1.3.0`, but are available in `1.5.0`: - `Compress` - `ConstantOfShape` - `EyeLike` - `NonMaxSuppression` - `NonZero` - `OneHot` - `Resize` - `RoiAlign` - `Scatter` - `Where` There are more operators, but these are the important ones, IMO. This PR doesn't implement any of the above operators, but just bumps the `ONNX` version in CI and fixes the tests for the newer version. ## Changes ## 1) The `implement onnx translation helpers` commit just implements some helper functions, that I've used in all my PRs for ONNX translations 2) Tests for trigonometric functions `sin`/`cos`, `acos`/`asin`/`atan` now have `[^h]` appended, so that it doesn't accidentally match with **new** ONNX test for the Hyperbolic trigonometric functions, the conversion for which is currently not implemented. (`test_sinh` etc) 3) Test `test_matmul` changed to `test_matmul_`, so that it doesn't accidentally match with the **new** ONNX test for `matmulinteger`, the conversion for which is currently not implemented. 4) Test `test_cast` changed to `test_cast((?!STRING).)*$`, so that it doesn't accidentally match with the **new** ONNX test for casting to/from strings. `((?!STRING).)*$` matches any text until the end of string, as long as it doesn't contain the word `STRING`. 5) Updated the implementation for exporting `topk` and `slice_axis` operators, since they changed their API in the new opset version. 6) Tests for `test_slice` and `test_topk` were disabled, since the new versions of the operators moved some of the attributes to inputs (`k` for `TopK`, and `starts`, `ends`, `axes` and `steps` for `Slice`). Since mxnet (afaik) doesn't fully support dynamic shapes yet, importing the newer operators is currently not possible. Importing `TopK` and `Slice` operators, exported with the older onnx version and exporting to the newer opset still works, so this shouldn't be a breaking change.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
