access2rohit commented on a change in pull request #18168:
URL: https://github.com/apache/incubator-mxnet/pull/18168#discussion_r417642124
##########
File path: src/operator/tensor/broadcast_reduce_op_value.cc
##########
@@ -128,7 +128,7 @@ NNVM_REGISTER_OP(_broadcast_backward)
.set_attr<FResourceRequest>("FResourceRequest",
[](const NodeAttrs& attrs) {
return std::vector<ResourceRequest>{ResourceRequest::kTempSpace};
- });
+});
Review comment:
Indent wasn't supposed to be there. It must align with NNVM. For
example:
https://github.com/apache/incubator-mxnet/blob/master/src/operator/tensor/matrix_op.cc#L446-L491
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
