access2rohit commented on a change in pull request #18324:
URL: https://github.com/apache/incubator-mxnet/pull/18324#discussion_r425359944
##########
File path: benchmark/opperf/README.md
##########
@@ -167,6 +167,41 @@ Output for the above benchmark run, on a CPU machine,
would look something like
]}
```
+
+## Usecase 5 - Profile internal operators locally
+Currently, opperf supports operators in `mx.nd.*` namespace.
+However, locally, one can profile internal operators in `mx.nd.internal.*`
namespace.
+
+#### Changes
+Remove the hasattr check for `op.__name__` to be in `mx.nd`
+
+The resulting diff would look like :
+```
Review comment:
Do you think rephrasing it to sth like from "old code" and to "new code"
would be easier instead on git diff ? Also separating both via code blocks
would be easier to read. Do you agree ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
